[Webkit-unassigned] [Bug 37630] delete redundant test outputs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37630





--- Comment #5 from Evan Martin <evan at chromium.org>  2010-04-16 13:31:04 PST ---
(In reply to comment #4)
> (From update of attachment 53398 [details])
> Tricky stuff.
> 
> No clue what this does:
> +        _, _, hash = attrs.split(' ')
> 
> Does that ignore the first two split values?

Yes.  Two features you might not be aware of:

1) foo, bar = x.split(' ')
unpacks into two variables.
2) _ = blah()
"_" is the name of the variable meaning "I don't want this variable".

That style is common for self-documenting the following:
 - throw an exception if the thing doesn't split into three components exactly
 - I don't care about the first two
It probably could be aided by including in a comment what kind of input it's
parsing.  (The git output is designed to be consumed by scripts in this way.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.