[Webkit-unassigned] [Bug 37688] Remove the optional shouldLazyAttach parameter from appendChild and friends

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37688





--- Comment #3 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2010-04-16 09:16:04 PST ---
(From update of attachment 53498)
> diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
> index c5e227e..24e1ee6 100644
> --- a/LayoutTests/ChangeLog
> +++ b/LayoutTests/ChangeLog
> @@ -1,3 +1,24 @@
> +2010-04-15  James Robinson  <jamesr at chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Update baselines affected by lazier attachment
> +        https://bugs.webkit.org/show_bug.cgi?id=37688
> +
> +        There are no user-visible changes, just a slightly different set of
> +        0-sized render objects in the render tree due to style recalcs/layouts
> +        happening at slightly different times.
> +
> +        * platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt:
> +        * platform/mac/fast/forms/basic-buttons-expected.txt:
> +        * platform/mac/fast/forms/formmove3-expected.txt:
> +        * platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
> +        * platform/mac/fast/invalid/003-expected.txt:
> +        * platform/mac/fast/invalid/table-residual-style-crash-expected.txt:
> +        * platform/mac/fast/table/014-expected.txt:
> +        * platform/mac/tables/mozilla/bugs/bug647-expected.txt:
> +        * platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:

You should go ahead and add results for Chromium as well -- or at least update
test_expectations.txt.

> -    
> -    // Should assert isBlockFlow || isInlineFlow when deletion improves. See 4244964.
> -    ASSERT(container->renderer());

Can you just remove these asserts? What were they for in the first place?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.