[Webkit-unassigned] [Bug 35607] Allow building smoothly on win32 and win64 using GCC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35607





--- Comment #52 from Adam Roben (aroben) <aroben at apple.com>  2010-04-15 14:13:24 PST ---
(In reply to comment #51)
>  - Windows x64 has 64-bit pointer, and this includes window handles and all
> that. MSVC warns, gcc errors out. That's why the casts need fixing. I'm not
> sure how to handle this now in WebCore/bridge/npapi.h. A Win32 handle now
> returns intptr_t's for x64 compatibility, not int or anything like that (see
> msdn).

Seems like we should figure out what plug-ins expect in 64-bit. (Are there any
64-bit plug-ins on Windows?) Looking at Firefox's code might help here.

>  - That I do not know. But it is also used as a value to store a pointer cast
> to void* which requires 64 bits of space on x64 windows, not provided by
> unsigned long on Win64. Again, gcc errors out, MSVC only warns. IMHO, I think
> nothing will break, as uintptr_t has the right type on mac and linux, and
> adapts to either
> 32-bit integer type on Windows x86, or
> 64-bit integer type on Windows x64. So I think it is the best choice.

OK, thanks for the explanation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.