[Webkit-unassigned] [Bug 37671] Add WebHistoryClient to WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37671


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-04-15 13:55:47 PST ---
Attachment 53471 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit2/UIProcess/API/C/WKNavigationData.cpp:26:  Found header this file
implements before WebCore config.h. Should be: config.h, primary header, blank
line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/WebHistoryClient.h:32:  Code inside a namespace should not be
indented.  [whitespace/indent] [4]
WebKit2/UIProcess/API/C/WKPage.cpp:127:  Weird number of spaces at line-start. 
Are you using a 4-space indent?  [whitespace/indent] [3]
WebKit2/UIProcess/WebHistoryClient.cpp:26:  Found header this file implements
before WebCore config.h. Should be: config.h, primary header, blank line, and
then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:49:  Alphabetical
sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/WebNavigationData.cpp:26:  Found header this file implements
before WebCore config.h. Should be: config.h, primary header, blank line, and
then alphabetically sorted.  [build/include_order] [4]
Total errors found: 6 in 21 files


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.