[Webkit-unassigned] [Bug 35915] [EFL] Add FrameLoaderClientEfl.{cpp, h} to WebKit/efl/WebCoreSupport
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 15 12:02:36 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=35915
Kenneth Rohde Christiansen <kenneth at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #50298|review?, commit-queue? |review+, commit-queue-
Flag| |
--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org> 2010-04-15 12:02:35 PST ---
(From update of attachment 50298)
On the mobile you probably want to say Mobile Safari and not Safari in the UA.
> +PassRefPtr<Frame> FrameLoaderClientEfl::createFrame(const KURL& url, const String& name, HTMLFrameOwnerElement* ownerElement,
> + const String& referrer, bool allowsScrolling, int marginWidth, int marginHeight)
Please keep these method definitions on one line.
Apart from that, it looks fine as an initial commit.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list