[Webkit-unassigned] [Bug 37645] [chromium] new-run-webkit-tests should be able to use chromium DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37645





--- Comment #6 from Dirk Pranke <dpranke at chromium.org>  2010-04-15 10:43:17 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #2)
> > > 1) What's the best way to switch to DRT?  This patch adds a command line flag,
> > > but we could also just auto-detect based on whether a chromium checkout exists.
> > 
> > I think command line switches are the way to go. Whether or not I have a
> > chromium checkout is orthogonal to whether or not I'll want to use DRT or
> > TestShell. I could see how it might make picking a default easier, but I
> > wouldn't bother with that.
> 
> Down with command line switches! Lets at least make it default to TestShell iff
> a chromium checkout exists and DRT otherwise. The only reason I'm not 100%
> against adding the commandline option is for people who have hybrid
> chromium/webkit checkouts.

Umm, yeah, I'm that person :) Given that I spend half my day flipping between
webkit tests and chromium tests and am very happy that I've managed to do it
all in a single checkout, please don't do things this way. Besides, the
switches will only be there temporarily.

If you want to smarten-up the default detection, that's fine w/ me. I wouldn't
bother, but I won't object.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.