[Webkit-unassigned] [Bug 37645] [chromium] new-run-webkit-tests should be able to use chromium DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37645





--- Comment #4 from Dirk Pranke <dpranke at chromium.org>  2010-04-15 10:22:18 PST ---
(In reply to comment #2)
> 1) What's the best way to switch to DRT?  This patch adds a command line flag,
> but we could also just auto-detect based on whether a chromium checkout exists.

I think command line switches are the way to go. Whether or not I have a
chromium checkout is orthogonal to whether or not I'll want to use DRT or
TestShell. I could see how it might make picking a default easier, but I
wouldn't bother with that.

> 2) I suppose we still want to build the helper binary and run them.  Do we want
> to use Chromium's image_diff or WebKit's ImageDiff?

We should merge the tools and only have one.

> 
> 3) Where should I write results to?  /tmp/layout-test-results to match other
> platforms?

See my comment in the review - I think this should still live in the build
directory (and I think we want other platforms to change to match this, as
well).

-- Dirk

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.