[Webkit-unassigned] [Bug 36500] Generated JIT stubs does not compile because of compiler directives

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36500





--- Comment #9 from David Leong <david.leong at nokia.com>  2010-04-15 09:32:20 PST ---
(In reply to comment #8)
> >  while ( $_ = <IN> ) {
> >      if ( /^$prefix\((.*)\)/ ) {
> >          $stub_template .= $1 . "\n";
> > +        #don't generate compiler directives
> > +        if( !$asm ) {
> > +            $makingstubs=1;
> > +        }
> >      }
> Why do you have the if(!$asm) inside of the loop?
> 
> > +    #don't print out extra #if blocks inside of functions
> > +    if( m/$openbrace/ && $makingstubs ) {
> > +    if( m/$closebrace/ && $makingstubs ) {
> I think the && $makingstubs can be removed.

Good catches, will correct this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.