[Webkit-unassigned] [Bug 32652] forward-declare libsoup types

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 15 08:18:48 PDT 2010


--- Comment #17 from Dan Winship <danw at gnome.org>  2010-04-15 08:18:47 PST ---
When we did the patches, webkit wasn't using SoupMessageFlags, but now it is,
so removing the soup.h include breaks it.

I don't know if it's allowed stylistically, but you could make m_soupFlags a
uint in ResourceRequest.h and ResourceResponse.h, and only cast to/from
SoupMessageFlags in ResourceResponseSoup.cpp.

Otherwise you'd need to submit a patch to libsoup to make SoupMessageFlags also
be "enum _SoupMessageFlags" (and probably fix everything else while you're
there too, so this doesn't happen again in the future), and then update the
patch here to use that.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list