[Webkit-unassigned] [Bug 35019] Can't cross-compile Qt/ARM anymore since r54616 (PluginViewNone.cpp vs. PluginView.cpp)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35019


Mirko Scavazzin <mscavazzin at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED
         Resolution|WORKSFORME                  |INVALID




--- Comment #4 from Mirko Scavazzin <mscavazzin at gmail.com>  2010-04-14 23:53:20 PST ---
I get still the same problems.

into PluginView.cpp
please change from this :
-----------------------------------------------------------------------------------------------
#if ENABLE(NETSCAPE_PLUGIN_API)
void PluginView::keepAlive(NPP instance)
{
    PluginView* view = instanceMap().get(instance);
    if (!view)
        return;

    view->keepAlive();
}
#endif

NPError PluginView::getValueStatic(NPNVariable variable, void* value)
{
    LOG(Plugins, "PluginView::getValueStatic(%s)",
prettyNameForNPNVariable(variable).data());

    NPError result;
    if (platformGetValueStatic(variable, value, &result))
        return result;

    return NPERR_GENERIC_ERROR;
}
-----------------------------------------------------------------------------------------------




to this:
-----------------------------------------------------------------------------------------------
#if ENABLE(NETSCAPE_PLUGIN_API)
void PluginView::keepAlive(NPP instance)
{
    PluginView* view = instanceMap().get(instance);
    if (!view)
        return;

    view->keepAlive();
}

NPError PluginView::getValueStatic(NPNVariable variable, void* value)
{
    LOG(Plugins, "PluginView::getValueStatic(%s)",
prettyNameForNPNVariable(variable).data());

    NPError result;
    if (platformGetValueStatic(variable, value, &result))
        return result;

    return NPERR_GENERIC_ERROR;
}
#endif
-----------------------------------------------------------------------------------------------












and into PluginViewNone.cpp
please change from this :
-----------------------------------------------------------------------------------------------
#if ENABLE(NETSCAPE_PLUGIN_API)
void PluginView::keepAlive(NPP)
{
}
#endif

void PluginView::privateBrowsingStateChanged(bool)
{
}

void PluginView::setJavaScriptPaused(bool)
{
}
-----------------------------------------------------------------------------------------------




to this:
-----------------------------------------------------------------------------------------------
#if ENABLE(NETSCAPE_PLUGIN_API)
void PluginView::keepAlive(NPP)
{
}

void PluginView::privateBrowsingStateChanged(bool)
{
}

void PluginView::setJavaScriptPaused(bool)
{
}
#endif
-----------------------------------------------------------------------------------------------

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.