[Webkit-unassigned] [Bug 37636] [DRT/Chromium] Implement DRT/Chromium for Windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 14 22:53:14 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37636


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #5 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-04-14 22:53:13 PST ---
Attachment 53411 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/DumpRenderTree/chromium/TestShellWin.cpp:33:  Found other header
before a header this file implements. Should be: config.h, primary header,
blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/DumpRenderTree/chromium/TestShellWin.cpp:34:  Found header this
file implements after other header. Should be: config.h, primary header, blank
line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/DumpRenderTree/chromium/TestShellWin.cpp:42:  Place brace on its
own line for function definitions.  [whitespace/braces] [4]
WebKitTools/DumpRenderTree/chromium/TestShellWin.cpp:65:  Place brace on its
own line for function definitions.  [whitespace/braces] [4]
WebKitTools/DumpRenderTree/chromium/TestShellWin.cpp:76:  Use 0 instead of
NULL.  [readability/null] [5]
WebKitTools/DumpRenderTree/chromium/TestShellWin.cpp:77:  Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons.  [readability/comparison_to_zero] [5]
WebKitTools/DumpRenderTree/chromium/TestShellWin.cpp:77:  Use 0 instead of
NULL.  [readability/null] [5]
WebKitTools/DumpRenderTree/chromium/TestShellWin.cpp:80:  Use 0 instead of
NULL.  [readability/null] [5]
WebKitTools/DumpRenderTree/chromium/TestShellWin.cpp:86:  Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons.  [readability/comparison_to_zero] [5]
WebKitTools/DumpRenderTree/chromium/TestShellWin.cpp:86:  Use 0 instead of
NULL.  [readability/null] [5]
Total errors found: 10 in 4 files


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list