[Webkit-unassigned] [Bug 37636] [DRT/Chromium] Implement DRT/Chromium for Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37636





--- Comment #2 from TAMURA, Kent <tkent at chromium.org>  2010-04-14 21:57:24 PST ---
(From update of attachment 53407)
The patch is ok.

> @@ -638,6 +642,7 @@ void LayoutTestController::pathToLocalResource(const CppArgumentList& arguments,
>      if (StartsWithASCII(url, "/tmp/", true)) {
>          // We want a temp file.
>          const unsigned tempPrefixLength = 5;
> +        // FIXME: replace the below with an existing library function such as file_util::GetTempDir()

nit: I don't think this FIXME is necessary. We should avoid to use file_util in
upstreamed code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.