[Webkit-unassigned] [Bug 37638] New: webkit-patch messed up

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37638

           Summary: webkit-patch messed up
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: simon.fraser at apple.com


Two issues with webkit-patch:
1. The recent change to show the diff as a pretty html file breaks if, on Mac
OS X, you set the owner of ".html" files to a text editor. It just opens the
.html file in a text editor, leading to confusion.

2. My patch included an new image result. The diff contained:

LayoutTests/platform/mac/fast/repaint/fixed-tranformed-expected.png

Exception raised during decoding git binary patch:
/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/open3.rb:67:in
`exec': No such file or directory - /opt/local/bin/git apply
--directory=/var/folders/OZ/OZ58r8WF2RaEz++1YxQZGU+++TI/-Tmp- (Errno::ENOENT)
    from
/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/open3.rb:67:in
`popen3'
    from
/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/open3.rb:53:in
`fork'
    from
/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/open3.rb:53:in
`popen3'
    from
/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/open3.rb:51:in
`fork'
    from
/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/open3.rb:51:in
`popen3'
    from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:337:in
`extract_contents_from_git_binary_chunk'
    from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:258:in
`initialize'
    from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:257:in
`collect'
    from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:257:in
`initialize'
    from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:309:in
`new'
    from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:309:in
`parse'
    from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:309:in
`collect'
    from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:309:in
`parse'
    from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:15:in
`prettify'
    from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/prettify.rb:26

/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:343:in
`extract_contents_from_git_binary_chunk'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:258:in
`initialize'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:257:in `collect'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:257:in
`initialize'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:309:in `new'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:309:in `parse'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:309:in `collect'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:309:in `parse'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:15:in `prettify'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/prettify.rb:26

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.