[Webkit-unassigned] [Bug 37561] [chromium] Add TestShellGtk.cpp so we can link on Linux

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 14 18:23:17 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37561


Tony Chang (Google) <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53395|                            |commit-queue?
               Flag|                            |




--- Comment #5 from Tony Chang (Google) <tony at chromium.org>  2010-04-14 18:23:16 PST ---
(From update of attachment 53395)
(In reply to comment #3)
> (From update of attachment 53322 [details])
> > --- a/WebKitTools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
> > +++ b/WebKitTools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
> > @@ -91,6 +91,7 @@
> >                  '../chromium/TestNavigationController.h',
> >                  '../chromium/TestShell.cpp',
> >                  '../chromium/TestShell.h',
> > +                '../chromium/TestShellGtk.cpp',
> >                  '../chromium/TestShellMac.mm',
> >                  '../chromium/TextInputController.cpp',
> >                  '../chromium/TextInputController.h',
> 
> Don't we need to have 'condition' block to exclude TestShellGtk.cpp for Mac ad
> TestShellMac.mm for non-Mac UNIX?

Yes, you're right.  I added exclude blocks for files ending in Gtk, Linux, Mac,
and Win.  We didn't need it before for Mac.mm because .mm is excluded in
common.gypi.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list