[Webkit-unassigned] [Bug 37622] [Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37622


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hausmann at webkit.org




--- Comment #2 from Simon Hausmann <hausmann at webkit.org>  2010-04-14 16:55:25 PST ---
A nicer way of achieving the same kind of private "API" would be to use dynamic
properties. So instead of using a private function

    QWebPage* page = ...
    qt_wrt_setViewMode(page, "foobar");

the client could would be much simpler:

    page->setProperty("wrt_viewMode", "foobar");


and QWebPage would receiver a QEvent::DynamicPropertyChange where the QEvent*
is actually a QDynamicPropertyChangeEvent.

Here's a link to the docs:
    http://doc.qt.nokia.com/4.6/qobject.html#setProperty

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.