[Webkit-unassigned] [Bug 36500] Generated JIT stubs does not compile because of compiler directives

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36500


David Leong <david.leong at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53371|                            |review?
               Flag|                            |




--- Comment #7 from David Leong <david.leong at nokia.com>  2010-04-14 14:55:37 PST ---
Created an attachment (id=53371)
 --> (https://bugs.webkit.org/attachment.cgi?id=53371)
Updated patch, as per review comments

Sorry for the late reply and update. I've been a bit busy with my other job :)

Updated the patch as per Gabor's comments, Patrick's comments and Laszlo's
comments.

Addressed Gabor's comments by adding the white space handling 

Addressed Patrick's comments by adding a new '--asm' argument to not print out
compiler directives. [A better fix in JITStubs.cpp is still needed I believe,
instead of moving the #ifs to inside functions. It works right now because
JIT_OPTIMIZE_PROPERTY_ACCESS and JIT_OPTIMIZE_CALL are defined.

Addressed Laszlo's comments (talked to him offline) by not reverting the
JITStub changes from 56842.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.