[Webkit-unassigned] [Bug 37603] Add WKRetainPtr helper class as private header

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37603


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53362|review?                     |review+
               Flag|                            |




--- Comment #3 from Anders Carlsson <andersca at apple.com>  2010-04-14 13:58:00 PST ---
(From update of attachment 53362)
> +
> +#define DECLARE_RETAIN_RELEASE_OVERLOADS(WKType) \
> +    inline void WKRetain(WKType##Ref p) { WKType##Retain(p); } \
> +    inline void WKRelease(WKType##Ref p) { WKType##Release(p); } \
> +    // end of macro
> +
> +DECLARE_RETAIN_RELEASE_OVERLOADS(WKContext)
> +DECLARE_RETAIN_RELEASE_OVERLOADS(WKFrame)
> +DECLARE_RETAIN_RELEASE_OVERLOADS(WKFramePolicyListener)
> +DECLARE_RETAIN_RELEASE_OVERLOADS(WKPage)
> +DECLARE_RETAIN_RELEASE_OVERLOADS(WKPageNamespace)
> +DECLARE_RETAIN_RELEASE_OVERLOADS(WKPreferences)
> +DECLARE_RETAIN_RELEASE_OVERLOADS(WKString)
> +DECLARE_RETAIN_RELEASE_OVERLOADS(WKURL)
> +
> +#undef DECLARE_RETAIN_RELEASE_OVERLOADS

Could you add a fixme about adding these overloads to the respective headers
(when compiling as C++).
> +template <typename T> inline void WKRetainPtr<T>::adoptCF(PtrType optr)

This shouldn't be here.

> +template <typename T> inline void WKRetainPtr<T>::adoptNS(PtrType optr)

Nor should this.

Looks good otherwise!

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.