[Webkit-unassigned] [Bug 36317] [EFL] Add EFL-specific code to Widget.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36317





--- Comment #25 from Eric Seidel <eric at webkit.org>  2010-04-14 12:56:03 PST ---
(From update of attachment 53328)
OK.  I think this can be OK.  We talked about this at length over IRC.

I'd like to see a patch posted with either // FIXME: comments or just normal
comments expaining why EFL is adding all this junk to Widget.

+#if PLATFORM(EFL)
+    // EFL needs to know whenever any object was moved or resized, so a
+    // null frameRectsChanged() implementation can't be used.
+    virtual void frameRectsChanged();
+#else
     virtual void frameRectsChanged() {}
+#endif

Should be done with a WidgetEFL.cpp file, like all the other overrides in
Widget.cpp are done.

+#if PLATFORM(EFL)
+    Evas* evas() const;
+
+    void setEvasObject(Evas_Object*);
+    Evas_Object* evasObject() const;
+
+    const String edjeTheme() const;
+    void setEdjeTheme(const String &);
+    const String edjeThemeRecursive() const;
+#endif

Shouldn't these just be free methods in some sort of WidgetEFL.h file?  They
coudl take the Widget or PlatformWidget as an argument since I"m sure that's
what you're using to compute this data.  Free methods are very c-like after
all. :)


I'm not sure what this is:
+    Ecore_Evas* ecoreEvas() const;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.