[Webkit-unassigned] [Bug 37565] new-run-webkit-tests needs a shared test_expectations.txt between all WebKit ports

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 14 11:18:36 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37565





--- Comment #1 from Dirk Pranke <dpranke at chromium.org>  2010-04-14 11:18:35 PST ---
The test_expectations and port/ structure was designed to share
test_expectations.txt files where possible, but there is a tradeoff between
sharing results across all ports and sharing results across a few ports (e.g.,
if we were to share text_expectations.txt between WebKit Mac and Chromium Mac,
then we would have to refer to port-specific diffs as "MAC" and "CHROMIUM-MAC".
This may make people unhappy).

I think it's more of a social question than a technical question. Technically,
sharing a single file would require us to have a common set of
test_platform_names() used by all the ports, and changing the path to the
test_expectations file to use it.

One other alternative we could do would be to support multiple
test_expectations files, and perhaps have a "generic" file that didn't have
port-specific or platform-specific expectations. This would perhaps only apply
to SLOW tests and CRASHes (and could maybe be used for REBASELINE).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list