[Webkit-unassigned] [Bug 37489] Use pretty patch for confirming webkit-patch diffs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37489





--- Comment #12 from Adam Barth <abarth at webkit.org>  2010-04-14 09:45:20 PST ---
(In reply to comment #11)
> Worrying about it later is OK.  I'm just ready to write the command as soon as
> you and I agree how. :)  Or You can write it.  Either way, it should be 10
> lines of python once we figure out how to keep the temp file around.
> 
> class PrettyDiff(AbstractDeclarativeCommand):
>     name = "pretty-diff"
>     help_text = "Open an HTML version of your current diff in a web browser."
> 
>     def execute(self, options, args, tool):
>         diff = tool.scm().create_patch()
>         pretty_diff = PrettyPatch().pretty_diff(diff)
>         # Stuff it in a file somehow?
>         User.open_url("file:///%s" % path_to_diff)

Right, the question is whether we want to leak the temp file.  IMHO, we might
want to leak the temp file when you invoke pretty-diff directly but clean up
the file when you run upload/post.  Another option is to use something like
run-safari, which seems to know how to block (because that's how the
LayoutTests work).  Another option is to re-use the mechanism for storing /
cleaning up layout test results (which I'm not sure what it is).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.