[Webkit-unassigned] [Bug 37489] Use pretty patch for confirming webkit-patch diffs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37489





--- Comment #10 from Adam Barth <abarth at webkit.org>  2010-04-14 09:31:26 PST ---
> Is:
> args = ["ruby","-I", pretty_patch_path, prettify_path]
> not PEP8 compliant?  Personally I find such a short command easier to read on
> one line.

It's probably fine.  In other cases when we've made an args array, we've ended
up tweaking it over time and eventually moved to the multiline version.  I can
change to back to single line if you like.

> How do we end up leaving the temp file open after termination then?  We need to
> for commands like:
> 
> webkit-patch pretty-diff
> 
> which would just open your current diff as a diff in a web browser and exit.

I'm inclined to worry about that when we create that command.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.