[Webkit-unassigned] [Bug 36317] [EFL] Add EFL-specific code to Widget.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 14 09:11:34 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36317


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53328|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #22 from Eric Seidel <eric at webkit.org>  2010-04-14 09:11:33 PST ---
(From update of attachment 53328)
I have no idea why Hyatt r+'d this before.

Two reviewers have now suggested using WidgetEFL, and there has been no
explanation from teh author why we would not, neither in the bug nor the
ChangeLog.

Please update the ChangeLog to explain why this change is done this way, or fix
ti to use WidgetEFL (assuming that's the modern way to do this type of
change?).  #ifdefs here seem super-ugly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list