[Webkit-unassigned] [Bug 37508] [Haiku] Rework FontPlatformData implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 14 07:36:36 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37508


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53283|review?                     |review-
               Flag|                            |




--- Comment #3 from David Levin <levin at chromium.org>  2010-04-14 07:36:36 PST ---
(From update of attachment 53283)
Only two minor things to fix up.

> Index: WebCore/platform/graphics/haiku/FontPlatformDataHaiku.cpp
> +static inline bool isEmtpyValue(const float size, const bool bold, const bool oblique)

typo: isEmtpyValue

> +class FontPlatformData::FontPlatformDataPrivate {
> +    FontPlatformDataPrivate(const BFont& font);

No need to include the parameter name "font" since it adds no new information.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list