[Webkit-unassigned] [Bug 37525] Make failure-reason more forgiving

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37525


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53286|review?                     |review+
               Flag|                            |




--- Comment #2 from Adam Roben (aroben) <aroben at apple.com>  2010-04-13 21:51:45 PST ---
(From update of attachment 53286)
> +            # FIXME: This could be made more user friendly.
> +            print "Failed to load layout test results start revision r%s, can't continue." % start_revision

I think this would be a little clearer like this: "Failed to load layout test
results; can't continue. (start revision = r%s)"

> @@ -237,8 +243,10 @@ class FailureReason(AbstractDeclarativeCommand):
>              results_to_explain -= fixed_results
>          if results_to_explain:
>              print "Failed to explain failures: %s" % results_to_explain
> +            return 1
>          else:
>              print "Explained all results for %s" % builder.name()
> +            return 0

Our C++ style is not to use "else" after "return".

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.