[Webkit-unassigned] [Bug 37070] [Qt] WebGL is not visible when QGLWidget viewport is used

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37070





--- Comment #11 from Kenneth Russell <kbr at google.com>  2010-04-13 16:44:09 PST ---
(From update of attachment 53267)
Looks good overall. One minor issue.

> diff --git a/WebKit/chromium/src/GraphicsContext3D.cpp b/WebKit/chromium/src/GraphicsContext3D.cpp
> index 9fbe899..19bff11 100644
> --- a/WebKit/chromium/src/GraphicsContext3D.cpp
> +++ b/WebKit/chromium/src/GraphicsContext3D.cpp
> @@ -1044,22 +1044,25 @@ rt GraphicsContext3D::name(t1 a1, t2 a2, t3 a3, t4 a4, t5 a5, t6 a6, t7 a7, t8 a
>      return m_internal->name(a1, a2, a3, a4, a5, a6, a7, a8, a9);   \
>  }
>  
> -GraphicsContext3D::GraphicsContext3D(GraphicsContext3D::Attributes attrs)
> +GraphicsContext3D::GraphicsContext3D(GraphicsContext3D::Attributes attrs, HostWindow* hostWindow)
>  {
> +    UNUSED_PARAM(hostWindow);
>  }
>  
>  GraphicsContext3D::~GraphicsContext3D()
>  {
>  }
>  
> -PassOwnPtr<GraphicsContext3D> GraphicsContext3D::create(GraphicsContext3D::Attributes attrs)
> +PassOwnPtr<GraphicsContext3D> GraphicsContext3D::create(GraphicsContext3D::Attributes attrs, HostWindow* hostWindow)
>  {
> +    UNUSED_PARAM(hostWindow);
> +

This UNUSED_PARAM is incorrect. The one in the constructor is correct.

Note that I'm not a WebKit reviewer. CC'ing a couple of other people who may be
able to provide r+ for subsequent patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.