[Webkit-unassigned] [Bug 36623] Relative URLs don't work for notifications in Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36623





--- Comment #14 from Aaron Boodman <aa at chromium.org>  2010-04-13 16:12:35 PST ---
(In reply to comment #11)
> Please add a few more details of exactly what you're doing here.

Done.

(In reply to comment #12)
> notifiications sp

Done.

> There are no functions listed here as is typical in changelogs.

Fixed.

> > +        Notification(const KURL& url, ScriptExecutionContext* context, ExceptionCode& ec, NotificationPresenter* provider);
> 
> (I know this isn't your fault but you're changing the line, so) I don't think
> any of these parameter names add anything except maybe "provider", so you
> should remove them.

Done.

> m_iconURL isn't used anymore as far as I can tell but you didn't remove it from
> the class.

Good catch, thanks. Done.

> notifiications sp

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.