[Webkit-unassigned] [Bug 36317] [EFL] Add EFL-specific code to Widget.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36317





--- Comment #18 from Chris Jerdonek <cjerdonek at webkit.org>  2010-04-13 15:59:37 PST ---
(In reply to comment #17)
> svn-apply seems to think that this patch is invalid:
> 
> 
> % curl "https://bugs.webkit.org/attachment.cgi?id=53205" --location | svn-apply
> Failed to find 'Index:' in:
> -------------------------------------------------------------------
> --- WebCore/ChangeLog
> +++ WebCore/ChangeLog
> @@ -1,3 +1,16 @@
> +2010-03-18  Leandro Pereira  <leandro at profusion.mobi>
> 
> Died at WebKitTools/Scripts/svn-apply line 337, <> line 94.
> % echo $?
> 255
> 
> I'm not sure why the commit-queue got all the way to the landing stage if
> svn-apply failed as such.

The submitted patch has no "Index:" line (as the svn-apply error states):

--- WebCore/ChangeLog
+++ WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2010-03-18  Leandro Pereira  <leandro at profusion.mobi>
+
+        Reviewed by NOBODY (OOPS!).
+
+        Add EFL-specific code to platform/Widget.h. We need

(from https://bugs.webkit.org/attachment.cgi?id=53205 )

FYI, Leandro seems to have had similar problems in the past:

https://bugs.webkit.org/show_bug.cgi?id=35234#c2
https://bugs.webkit.org/show_bug.cgi?id=37478#c10

Leandro, are you using svn-create-patch, git diff, or an equivalent?  Are you
modifying your patches by hand in some way prior to submitting?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.