[Webkit-unassigned] [Bug 34683] [Haiku] Implement Path, Gradient and flesh out GraphicsContextHaiku

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34683


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49527|review?                     |review-
               Flag|                            |




--- Comment #17 from David Levin <levin at chromium.org>  2010-04-13 14:06:14 PST ---
(From update of attachment 49527)
Just a few minor nits. Sorry (I would r+ if you could land it).

> Index: WebCore/ChangeLog
> +            Fixed memory corruption, curtesy of Michael Lotz. We can't just assign pointers!

courtesy 

> +        (WebCore::Path::addQuadCurveTo):
> +            Implemented (curtesy of Michael Lotz).

courtesy 


> Index: WebCore/platform/graphics/haiku/PathHaiku.cpp
> +// A one pixel sized BBitmap for drawing into. Default high-color of BViews

Single space after . in comments.


> +        virtual status_t IterateLineTo(int32 lineCount, BPoint* linePts)

Abbreviations are discouraged in WebKit. "Pts".

> +    // BShapeIterator allows us to modify the path data "in place"

Please add a "."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.