[Webkit-unassigned] [Bug 37481] Minor fix to pass RenderProgress instead of RenderObject

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37481





--- Comment #4 from Eric Seidel <eric at webkit.org>  2010-04-13 09:40:52 PST ---
The reviewer_text string parsed with ChangeLogEntry._parse_entry() does not
seem to be unicode.  When I attempt to convert it to unicode I get:

Parsing ChangeLog: /Projects/WebKit/WebCore/ChangeLog
Traceback (most recent call last):
  File "/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 56, in
<module>
    main()
  File "/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 51, in main
    WebKitPatch(__file__).main()
  File
"/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line
302, in main
    result = command.check_arguments_and_execute(options, args, self)
  File
"/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line
113, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/commands/upload.py",
line 57, in execute
    print "%s" % tool.checkout().commit_message_for_this_commit().message()
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/api.py",
line 99, in commit_message_for_this_commit
    changelog_entry = ChangeLog(changelog_path).latest_entry()
  File
"/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/changelog.py",
line 121, in latest_entry
    return self.parse_latest_entry_from_file(changelog_file)
  File
"/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/changelog.py",
line 114, in parse_latest_entry_from_file
    return ChangeLogEntry(''.join(entry_lines[:-1]))
  File
"/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/changelog.py",
line 53, in __init__
    self._parse_entry()
  File
"/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/changelog.py",
line 66, in _parse_entry
    print unicode(self._reviewer_text)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 14:
ordinal not in range(128)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.