[Webkit-unassigned] [Bug 37502] Web Inspector: Removes public callLocation API from ScriptCallStack and replaces with ability to get top 10 stack frames

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 13 08:53:10 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37502





--- Comment #1 from jaimeyap at google.com  2010-04-13 08:53:09 PST ---
Created an attachment (id=53257)
 --> (https://bugs.webkit.org/attachment.cgi?id=53257)
patch

I would like feedback on the general approach. One thing to note is that my
measurements show that grabbing the stack trace only adds 1 to 3ms in the worse
case to a node. This can add up for traces with hundreds or thousands of nodes.
So I have implemented a simple cache for the current stack trace in
InspectorTimelineAgent.cpp

The rationale is that the JS Stack trace, once acquired will be unchanged until
we run some javascript. This means we invalidate the cached stack trace on
ScriptEvaluation, FunctionCalls, or when we pop the record stack.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list