[Webkit-unassigned] [Bug 37385] [Haiku] Use all the new system cursors in CursorHaiku.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 12 23:37:06 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37385


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53097|review?                     |review-
               Flag|                            |




--- Comment #4 from David Levin <levin at chromium.org>  2010-04-12 23:37:06 PST ---
(From update of attachment 53097)
> Index: WebCore/ChangeLog
> +2010-04-11  Stephan Aßmus  <superstippi at gmx.de>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Haiku] Use all the new system cursors available in recent Haiku revisions.
> +        <https://bugs.webkit.org/show_bug.cgi?id=37385>
> +
> +        Covered by existing tests.
> +
> +        * platform/Cursor.h:
> +            - Added necessary include.
> +            - Changed definitions of PlatformCursor and PlatformCursorHandle.

It is clear that you did this but why you did it is unclear. This results in an
ifdef in Cursor.h (to change the return type of impl()) where all other ports
have been able to avoid it.

r- due to new ifdef which changes the return type of impl().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list