[Webkit-unassigned] [Bug 37487] Make new-run-webkit-test PrettyPatch failure reporting more awesome

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37487





--- Comment #4 from Dirk Pranke <dpranke at chromium.org>  2010-04-12 21:42:58 PST ---
(From update of attachment 53222)
>          command = ["ruby", "-I", pretty_patch_path, prettify_path, diff_path]
>          try:
>              return self._executive.run_command(command)
>          except OSError, e:
> -            # If they system is missing ruby just log the error, and stop trying.
> +            # If the system is missing ruby log the error and stop trying.
>              _pretty_patch_available = False
> -            return "Failed to run PrettyPatch: %s" % e
> -        except Executive.ScriptError, e:
> -            # If they system is missing ruby just log the error, and stop trying.
> +            _log.error("Failed to run PrettyPatch (%s): %s" % (command, e))
> +            return self._pretty_patch_error_html
> +        except ScriptError, e:
> +            # If ruby failed to run for some reason, log the command output and stop trying.
>              _pretty_patch_available = False
> -            return "Failed to run PrettyPatch: %s" % e
> +            _log.error("Failed to run PrettyPatch (%s):\n%s" % (command, e.message_with_output()))
> +            return self._pretty_patch_error_html
>

Why does this routine have to catch either a ScriptError or an OSError? It
seems like maybe the run_command() semantics aren't clear?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.