[Webkit-unassigned] [Bug 37218] Implement FileStreamProxy that calls FileStream methods on FileThread for FileAPI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 12 18:26:44 PDT 2010


--- Comment #22 from Kinuko Yasuda <kinuko at chromium.org>  2010-04-12 18:26:43 PST ---
(In reply to comment #20)
> (In reply to comment #19)
> > Asserting on ref count makes me a bit nervous, so I added another status flag
> > to allow recycling even after stop() (just in case).
> Is there any scenario we want to support reusing FileStreamProxy after calling
> stop()? If not at present, I'd rather keep the semantic strict because it is
> kind of confusing. Normally we assume calling something like start() or
> restart() to revive the instance. But with your new patch, calling any other
> methods of FileStreamProxy could trigger the reviving and this could make it
> easy to make the mistake.

Ah ok FileReader has a reason to make it strict. (I changed like that since in
FileWriter I didn't see a reason to force the caller to deref the proxy after
Added the ASSERT as you suggested in your previous review.  Also added a line
to nullify the client in stop() to avoid calling back on the client after

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list