[Webkit-unassigned] [Bug 36623] Relative URLs don't work for notifications in Chromium
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 12 11:20:53 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=36623
David Levin <levin at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |levin at chromium.org
--- Comment #12 from David Levin <levin at chromium.org> 2010-04-12 11:20:51 PST ---
It looks like jorlow r+'ed this.
Anyway, I think the following items should be addressed.
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index 6f8e025..72aa8d5 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,13 @@
> +2010-04-09 Aaron Boodman <aa at chromium.org>
> +
> + Reviewed by NOBODY (OOPS!).
> +
> + Support relative URLs for notifiications on Chromium.
notifiications sp
> + https://bugs.webkit.org/show_bug.cgi?id=36623
> +
> + Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.
> + John is going to add this soon and will add a test for this at that time.
There are no functions listed here as is typical in changelogs.
> diff --git a/WebCore/notifications/Notification.cpp b/WebCore/notifications/Notification.cpp
> diff --git a/WebCore/notifications/Notification.h b/WebCore/notifications/Notification.h
> + Notification(const KURL& url, ScriptExecutionContext* context, ExceptionCode& ec, NotificationPresenter* provider);
(I know this isn't your fault but you're changing the line, so) I don't think
any of these parameter names add anything except maybe "provider", so you
should remove them.
m_iconURL isn't used anymore as far as I can tell but you didn't remove it from
the class.
> diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
> +2010-04-09 Aaron Boodman <aa at chromium.org>
> +
> + Reviewed by NOBODY (OOPS!).
> +
> + Support relative URLs for notifiications on Chromium.
notifiications sp
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list