[Webkit-unassigned] [Bug 37292] http://trac.webkit.org/changeset/57215 caused perf/memory regressions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 12 11:01:45 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37292





--- Comment #12 from Enrica Casucci <enrica at apple.com>  2010-04-12 11:01:44 PST ---
(In reply to comment #11)
> (In reply to comment #9)
> > Yeah I really should not have put r+ on the original bug.  I'll take some of
> > the blame for that.  It was obvious that the bug was going to regress the
> > performance of the complex text code path, and I shouldn't have let that slide.
> 
> According to Ojan’s testing, that is not correct. The complex path has not
> become measurably slower.
> 
> > We should probably do a surgical patch that disables this tracking without
> > removing all the code from the tree, so that we can get the performance back.
> 
> I think the thinks to consider now are:
> 1) Add a third code path (fast w/glyph overflow) for the “stacked diacritics”
> range
> or if that turns out to be too hard
> 2) #ifdef-out the change to canUseGlyphCache()

I believe there is some confusion here.
Unless Ojan tests provide a different picture of the problem, here is where I
think we stand:
1. we no performance impact for the simple text path
2. we have very small impact on the complex text path (but I don't have the
exact numbers)
3. where things have gotten worse is where we started using the complex path
for cases where we used to use the simple one.

I will address number 3 shortly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list