[Webkit-unassigned] [Bug 36883] [Qt] Parallel painting in WebKit
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 12 07:07:53 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=36883
WebKit Review Bot <webkit.review.bot at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |webkit-bot-watchers at googleg
| |roups.com,
| |webkit.review.bot at gmail.com
--- Comment #7 from WebKit Review Bot <webkit.review.bot at gmail.com> 2010-04-12 07:07:51 PST ---
Attachment 53162 did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/qt/ImageBufferData.h:32: Alphabetical sorting
problem. [build/include_order] [4]
WebCore/platform/graphics/PaintThreadMessage.h:37: Alphabetical sorting
problem. [build/include_order] [4]
WebCore/platform/graphics/PaintThreadMessage.h:44: Alphabetical sorting
problem. [build/include_order] [4]
WebCore/platform/graphics/PaintThreadMessage.h:58: Code inside a namespace
should not be indented. [whitespace/indent] [4]
WebCore/platform/graphics/PaintThreadMessage.h:371: An else statement can be
removed when the prior "if" concludes with a return, break, continue or goto
statement. [readability/control_flow] [4]
WARNING: File exempt from style guide. Skipping:
"WebKit/qt/Api/qwebhistory.cpp"
WebCore/platform/graphics/qt/GraphicsContextQt.cpp:53: Alphabetical sorting
problem. [build/include_order] [4]
WebCore/platform/graphics/GraphicsContext.h:36: Alphabetical sorting problem.
[build/include_order] [4]
WebCore/platform/graphics/PaintThreadRunLoop.cpp:31: You should add a blank
line after implementation file's own header. [build/include_order] [4]
WebCore/platform/graphics/PaintThreadRunLoop.cpp:69: Declaration has space
between type name and * in GraphicsContext *context [whitespace/declaration]
[3]
WebCore/platform/graphics/PaintThreadRunLoop.cpp:71: Declaration has space
between type name and * in QPainter *painter [whitespace/declaration] [3]
WebCore/platform/graphics/PaintThreadRunLoop.cpp:79: Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons. [readability/comparison_to_zero] [5]
WebCore/platform/graphics/PaintThreadRunLoop.cpp:118: Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons. [readability/comparison_to_zero] [5]
WebCore/platform/graphics/PaintThreadRunLoop.cpp:190: Should have a space
between // and comment [whitespace/comments] [4]
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebframe.cpp"
WARNING: File exempt from style guide. Skipping:
"WebKit/qt/Api/qwebsettings.cpp"
WebCore/platform/graphics/Image.h:64: Alphabetical sorting problem.
[build/include_order] [4]
WebCore/platform/graphics/PaintThread.h:41: Code inside a namespace should not
be indented. [whitespace/indent] [4]
Total errors found: 15 in 35 files
If any of these errors are false positives, please file a bug against
check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list