[Webkit-unassigned] [Bug 37436] [Chromium] Select popups assert when destroyed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37436


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-04-11 23:23:59 PST ---
Attachment 53153 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/tests/PopupMenuTest.cpp:33:  Found other header before a header
this file implements. Should be: config.h, primary header, blank line, and then
alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/PopupMenuTest.cpp:35:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/chromium/tests/PopupMenuTest.cpp:37:  Found header this file implements
after other header. Should be: config.h, primary header, blank line, and then
alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/PopupMenuTest.cpp:39:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/chromium/tests/PopupMenuTest.cpp:179:  Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 5 in 7 files


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.