[Webkit-unassigned] [Bug 37406] Add PrettyPatch links to new-run-webkit-tests output

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37406





--- Comment #5 from Dirk Pranke <dpranke at chromium.org>  2010-04-11 11:35:35 PST ---
(From update of attachment 53079)
> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
> index b1e0733..33893f6 100644
> --- a/WebKitTools/ChangeLog
> +++ b/WebKitTools/ChangeLog
> @@ -1,3 +1,27 @@
> +2010-04-11  Eric Seidel  <eric at webkit.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Add PrettyPatch links to new-run-webkit-tests output
> +        https://bugs.webkit.org/show_bug.cgi?id=37406
> +

Does this patch introduce a dependency on Ruby into the test system? I don't
think we have
Ruby on Chromium windows (and am not sure about Linux, although it's probably
there).

Also, do we really need three different kinds of diffs?

> @@ -519,6 +519,7 @@ class Port(object):
>                 '--end-insert=##WDIFF_END##',
>                 actual_filename,
>                 expected_filename]
> +        # FIXME: Why not just check os.exists(executable) once?
>          global _wdiff_available

See the comments in base.py's Port.wdiff_text()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.