[Webkit-unassigned] [Bug 36317] [EFL] Add EFL-specific code to Widget.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36317





--- Comment #9 from Gustavo Sverzut Barbieri <barbieri at profusion.mobi>  2010-04-10 18:00:55 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > We need this at the widget level, we must be informed about the frameRect
> > changed so we can act. Unlike other ports, our plugins and other visual
> > elements (scrollbars) are not moved automatically. We also need to update our
> > clippers if we use backing store that is bigger than the current viewport.
> 
> Sorry, I may not have been clear enough. I am not suggesting you move it
> outside of the Widget level. I'm just suggesting you use a port specific
> WidgetEfl.h, like other classes do. I haven't looked at how difficult that
> would be, but I don't think it should be too difficult.

But the patch would be as intrusive, no? What is good in leaving the #ifndef in
Widget.h and the #ifdef in the WidgetEfl.h? I guess it is overcomplicating for
no greater benefit. MAC already have similar pattern down in the same file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.