[Webkit-unassigned] [Bug 37393] Sketch out the win port for new-run-webkit-tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37393





--- Comment #10 from Dirk Pranke <dpranke at chromium.org>  2010-04-10 17:25:29 PST ---
(In reply to comment #9)
> > Note that this'll put the test_expectations.txt file in
> > LayoutTests/platform/{win,mac}, instead
> > of having a common one shared by all of the WebKit variations. Are you sure you
> > want this? If you
> > do, you probably don't want to return multiple test_base_platform_names().
> 
> I'm not sure what we want to do here.  Currently the test_expectation.txt file
> is in LayoutTests/platform/mac, so I went with that.

Maybe I'm not following you, but the code now will return
platform/mac/test_expectations.txt when running on a mac, and
platform/win/test_expectations.txt when running on windows. I.e., you'll have
two files to update, which defeats the point a bit. 

Perhaps we should put the "base" version in LayoutTests/test_expectations.txt
and the various ports can decide if they want to pile into the base version or
use their own like Chromium does.

Alternatively, we could have a "platform/webkit" directory for this file and
any baselines that produce webkit-specific output (e.g., for text errors
specific to JSC, etc.).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.