[Webkit-unassigned] [Bug 37393] Sketch out the win port for new-run-webkit-tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37393





--- Comment #8 from Dirk Pranke <dpranke at chromium.org>  2010-04-10 17:13:03 PST ---
(In reply to comment #3)
> (From update of attachment 53057 [details])
>  43             if options and hasattr(options, 'chromium') and
> options.chromium:
>
> should just be options.chromium, no?

No. options.chromium isn't guaranteed to be set, so you need the extra tests.

>
> What's this used for?
> 190191     def test_base_platform_names(self):

See the comments in base.py.

> 84     def test_platform_name(self):
> 280          raise NotImplementedError('WebKitPort.test_platform_name')
>  285         return self._name + self.version()
>

Yes, it's as good a thing to return as any. Again, see the comments in the base
class for what the function does.

> Why?
> 48     def version(self):
>  49         return ''

WebKit doesn't keep different versions of the baselines for different versions
of windows, so there's no need for a version string here (just like chromium on
the mac doesn't version, but webkit mac does).


(In reply to comment #3)
> (From update of attachment 53057 [details])
>  43             if options and hasattr(options, 'chromium') and
> options.chromium:
> 
> should just be options.chromium, no?
> 
> What's this used for?
> 190191     def test_base_platform_names(self):
> 
> are you sure it shoudl return "win" as well as mac?
> 
> God I had 80c wrap:
> 245         return [os.path.join(self._webkit_baseline_path(self._name,
>  246                                                             'Skipped'))]
> 
> What's this used for?  Is this right?
> 84     def test_platform_name(self):
> 280          raise NotImplementedError('WebKitPort.test_platform_name')
>  285         return self._name + self.version()
> 
> Why?
> 48     def version(self):
>  49         return ''
> 
> Portname override is lame:
> 43     def __init__(self, port_name=None, options=None):
>  44         if port_name is None:
>  45             port_name = 'win'
> 
>  63     def _tests_for_disabled_features(self):
>  is a copy/paste disaster.  Can't that be pushed into WebKitPort?
> 
> Please respond to the comments.  Otherwise this looks like an OK first start.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.