[Webkit-unassigned] [Bug 37393] Sketch out the win port for new-run-webkit-tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37393





--- Comment #7 from Dirk Pranke <dpranke at chromium.org>  2010-04-10 17:04:12 PST ---
(From update of attachment 53057)
> diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py b/WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py
> index f4c2433..a943b77 100644
> --- a/WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py
> +++ b/WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py
> @@ -65,7 +65,11 @@ class WebKitPort(base.Port):
>          return self._webkit_baseline_path(self._name)
>  
>      def baseline_search_path(self):
> -        raise NotImplementedError('WebKitPort.baseline_search_path')
> +        return [self._webkit_baseline_path(self._name)]
> +
> +    def path_to_test_expectations_file(self):
> +        return os.path.join(self._webkit_baseline_path(self._name),
> +                            'test_expectations.txt')

Note that this'll put the test_expectations.txt file in
LayoutTests/platform/{win,mac}, instead
of having a common one shared by all of the WebKit variations. Are you sure you
want this? If you
do, you probably don't want to return multiple test_base_platform_names().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.