[Webkit-unassigned] [Bug 37387] run_webkit_tests.py shouldn't have platform-specific logic

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37387





--- Comment #4 from Adam Barth <abarth at webkit.org>  2010-04-10 12:43:14 PST ---
Thanks.  Executive.cpu_count shouldn't exist.  It only exits because the
multiprocessing package is in Python 2.6 and later.  We shouldn't have a bunch
of different pieces of code that work around the lack of the multiprocessing. 
In principle, we could just implement our own version of multiprocessing, like
we do for os.relpath, but we decide to put it on executive so it could be
non-static (which is better for testing).

The main point of this patch is that it makes sense for a WebKit port to
recommend a default number of DRT instances.  It doesn't make a lot of sense
for a WebKit port to tell you how many CPUs your machine has.  Some lower-level
piece of code should do that.  The webkitpy.common.system package houses all
the non-WebKit specific code for interacting with the operating system (that
isn't supplied by the standard library), so the CPU counting code should live
there.  Now, what to do with the CPU count, that's a question for the
layout_test package.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.