[Webkit-unassigned] [Bug 37369] [GTK] Enable building whatever already exists of WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37369





--- Comment #2 from Mark Rowe (bdash) <mrowe at apple.com>  2010-04-09 16:04:19 PST ---
(In reply to comment #1)
> Created an attachment (id=53003)
 --> (https://bugs.webkit.org/attachment.cgi?id=53003) [details]
> non-working work in progress patch
> 
> I started playing around with this, but I have to go away for a while, so I
> thought I'd upload what I already did. I haven't been too careful about
> correctness yet, just poked, and massaged stuff. I am trying to get a
> convenience library called libwebkit2 built from the Platform/ and Shared/
> directories, essentially.
> 
> Notes:
> 
> * It looks like the plan is to avoid using config.h in WebKit2, but I have
> added it in some places in this first try;

The platforms that are currently supported all support prefix headers, so
there’s no need to explicitly do prefix includes in this manner.  We may decide
that it is a good idea to match the explicit style we use in JavaScriptCore and
WebCore, or we may find that it is necessary because some platforms do not
support prefix headers.

> * I am using OS(LINUX) in places that need a non-toolkit-specific,
> platform-specific typedef, for now, without really looking at its correctness
> in detail;
> * Some files use "WebCore/<File>.h" paths for inclusion, that may or may not be
> related to changes that were done to WebCore's directory structure and will be
> landed in the future. Some examples:
> 
> #include <WebCore/FloatRect.h>
> #include <WebCore/PlatformString.h>

This is a Mac OS X-style framework include.  We’ll need to work out which
approach we want to use to handle including WebCore headers in a cross-platform
manner within WebKit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.