[Webkit-unassigned] [Bug 37368] Add MiniBrowser for new WebKit API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37368


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-04-09 15:36:05 PST ---
Attachment 53002 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit2/MiniBrowser/win/main.cpp:26:  Found other header before WebCore
config.h. Should be: config.h, primary header, blank line, and then
alphabetically sorted.  [build/include_order] [4]
WebKit2/MiniBrowser/win/main.cpp:28:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit2/MiniBrowser/mac/BrowserWindowController.h:36:  _pageNamespace is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
WebKit2/MiniBrowser/win/MiniBrowser.cpp:26:  Found other header before WebCore
config.h. Should be: config.h, primary header, blank line, and then
alphabetically sorted.  [build/include_order] [4]
WebKit2/MiniBrowser/win/MiniBrowser.cpp:27:  Found header this file implements
after other header. Should be: config.h, primary header, blank line, and then
alphabetically sorted.  [build/include_order] [4]
WebKit2/MiniBrowser/win/resource.h:1:  Should have a space between // and
comment  [whitespace/comments] [4]
WebKit2/MiniBrowser/win/stdafx.cpp:30:  Found header this file implements
before WebCore config.h. Should be: config.h, primary header, blank line, and
then alphabetically sorted.  [build/include_order] [4]
WebKit2/MiniBrowser/win/BrowserView.cpp:26:  Found other header before WebCore
config.h. Should be: config.h, primary header, blank line, and then
alphabetically sorted.  [build/include_order] [4]
WebKit2/MiniBrowser/win/BrowserView.cpp:27:  Found header this file implements
after other header. Should be: config.h, primary header, blank line, and then
alphabetically sorted.  [build/include_order] [4]
WebKit2/MiniBrowser/win/BrowserWindow.cpp:26:  Found other header before
WebCore config.h. Should be: config.h, primary header, blank line, and then
alphabetically sorted.  [build/include_order] [4]
WebKit2/MiniBrowser/win/BrowserWindow.cpp:27:  Found header this file
implements after other header. Should be: config.h, primary header, blank line,
and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 11 in 26 files


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.