[Webkit-unassigned] [Bug 37275] Accessibility support for progress element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37275


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52890|review?                     |review+
               Flag|                            |




--- Comment #4 from Darin Adler <darin at apple.com>  2010-04-09 09:22:22 PST ---
(From update of attachment 52890)
> +class AccessibilityProgressIndicator : public AccessibilityRenderObject {
> +    
> +public:
> +    static PassRefPtr<AccessibilityProgressIndicator> create(RenderObject*);
> +
> +private:
> +    virtual AccessibilityRole roleValue() const { return ProgressIndicatorRole; }
> +
> +    virtual bool isProgressIndicator() const { return true; }
> +
> +    virtual float valueForRange() const;
> +    virtual float maxValueForRange() const;
> +    virtual float minValueForRange() const;
> +
> +    AccessibilityProgressIndicator(RenderObject*);
> +
> +private:
> +    HTMLProgressElement* element() const;
> +    virtual bool accessibilityIsIgnored() const;
> +};

Extra blank line before public here. The argument type should be
RenderProgress* rather than RenderObject* to make it clear it's illegal to call
this with another kind of RenderObject. No need to say "private" twice. r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.