[Webkit-unassigned] [Bug 37025] Web Inspector: GC Run event should be added to Timeline Panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37025





--- Comment #25 from jaimeyap at google.com  2010-04-09 09:15:07 PST ---
(In reply to comment #24)
> Your findings are correct. Shortly speaking, GC events are never reported
> synchronously. The reason is that we can't run JavaScript code from within GC
> event, while front-end push is implemented using javascript code. All the calls
> into ScriptObject are JS calls in fact.
> 
> The only good way of handling this (and we've been considering it for a long
> time + it was the original implementation in Chromium downstream) is to use
> native structures in place of ScriptValue/Object/Array that would natively
> serialize into JSON. They are called Value in Chromium (see base/values.h).
> They can be serialized to JSON using not that much code:
> http://src.chromium.org/viewvc/chrome/trunk/src/base/json/json_writer.cc. 
> Unfortunately, json_reader.cc is much larger and more complex, but I think we
> could work out solution that does not require it - stuff will still be parsed
> in the js environment. I would do it all right away if I had resources.

I understand the not being able to send a record synchronously from the GC
callback. But I am not certain that we need to in order to fix the wrong parent
bug. I have a patch that I believe resolves the issue:

https://bugs.webkit.org/show_bug.cgi?id=37340

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.