[Webkit-unassigned] [Bug 37340] New: Web Inspector: Fixes "wrong parent" for GCEvents that come at the end of a timeline record node.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37340

           Summary: Web Inspector: Fixes "wrong parent" for GCEvents that
                    come at the end of a timeline record node.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jaimeyap at google.com
                CC: timothy at hatcher.name, knorton at google.com,
                    pfeldman at chromium.org, loislo at chromium.org


This patch fixes "wrong parent" for GCEvents that come at the end of a timeline
record node.

The problem was as follows:

InspectorTimelineAgent::didCompleteRecord() pops the record stack and then
calls addRecordToTimeline()

addRecordToTimeline() pushes the GCEvents. This then attributes the GCEvents to
whatever is currently last on the record stack. Too bad the real parent has
already been popped :).

This means that the only time GCEvents are correctly parented are when they
happen to get pushed by some other peer node closing BEFORE their parent tries
to pop.

The solution:

Add a call to pushGCEventRecords() to didCompleteCurrentRecord(). Simply remove
the call to pushGCEventRecords() from addRecordToTimeline() and just ensure
that callers of addRecordToTimeline() push the GCEvents if they need to.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.