[Webkit-unassigned] [Bug 37308] [Chromium] Support HTML5 <progress> element on Windows.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37308





--- Comment #5 from TAMURA, Kent <tkent at chromium.org>  2010-04-09 00:28:34 PST ---
(From update of attachment 52941)
> --- a/WebCore/rendering/RenderThemeChromiumWin.cpp
> +++ b/WebCore/rendering/RenderThemeChromiumWin.cpp
> @@ -38,6 +38,7 @@
>  #include "HTMLNames.h"
>  #include "MediaControlElements.h"
>  #include "RenderBox.h"
> +#include "RenderProgress.h"
>  #include "RenderSlider.h"
>  #include "ScrollbarTheme.h"
>  #include "TransparencyWin.h"
> @@ -653,4 +654,55 @@ bool RenderThemeChromiumWin::paintTextFieldInternal(RenderObject* o,
>      return false;
>  }
>  
> +#if ENABLE(PROGRESS_TAG)
> +
> +static const double progressAnimationFrameRate = 0.033;
> +static const double progressAnimationNumFrames = 60;

How did you decide these values?  Do they match to Windows' behavior?

> --- a/WebKit/chromium/ChangeLog
> +++ b/WebKit/chromium/ChangeLog
> @@ -1,3 +1,19 @@
> +2010-04-08  MORITA Hajime  <morrita at google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Chromium] Support HTML5 <progress> element on Windows.
> +        https://bugs.webkit.org/show_bug.cgi?id=37308
> +
> +        Extended ChromiumBridge and WebThemeEngine interface
> +        to handle progress bar painting. implementation will 
> +        shit on Chromium tree.

I don't understand the last sentence. shit?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.