[Webkit-unassigned] [Bug 37299] Missing return value in TCMalloc_ThreadCache::GetThreadHeap()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 8 18:01:18 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37299





--- Comment #3 from Mark Rowe (bdash) <mrowe at apple.com>  2010-04-08 18:01:18 PST ---
(In reply to comment #2)
> I am building it with HAVE_TLS defined because TLS is *much* faster than
> pthread_getspecific() on my platform.

Ok.  You’ll probably want to be aware of the fact that this code-path is
completely untested in our version of TCMalloc.

> Also looking at the code, I don't think you are correct.

You’re right, I didn’t match up the nested #if’s correctly.  It’s still true
that HAVE_TLS is never defined on any platforms that build from the WebKit
tree.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list